Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: broken url on booking page #15028

Merged
merged 9 commits into from
May 23, 2024
Merged

fix: broken url on booking page #15028

merged 9 commits into from
May 23, 2024

Conversation

Udit-takkar
Copy link
Contributor

@Udit-takkar Udit-takkar commented May 14, 2024 •
edited

What does this PR do?

Regression from https://github.com/calcom/cal.com/pull/14777/files.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected)
  • I have added a Docs issue here if this PR makes changes that would require a documentation change
  • I have added or modified automated tests that prove my fix is effective or that my feature works (PRs might be rejected if logical changes are not properly tested)

How should this be tested?

  1. Go to any team event type url and make sure team logo is not visible. (for non org event types)

@linear Linear
Copy link

linear bot commented May 14, 2024

CAL-3702 Back to Homapage flow not working

@graphite-app graphite-app bot requested a review from a team May 14, 2024 13:46
@Udit-takkar Udit-takkar added this to the v4.1 milestone May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore. labels May 14, 2024
@Udit-takkar Udit-takkar requested a review from emrysal May 14, 2024 13:46
@keithwillcode keithwillcode added consumer core area: core, team members only labels May 14, 2024
@dosubot dosubot bot added booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working labels May 14, 2024
@dosubot dosubot bot modified the milestones: v4.1, v4.2 May 14, 2024
Udit-takkar
Udit-takkar commented May 14, 2024
View reviewed changes
packages/features/bookings/components/event-meta/Members.tsx Outdated
Comment on lines 33 to 40
{
// We don't want booker to be able to see the list of other users or teams inside the embed
href: isEmbed ? null : getBookerBaseUrlSync(entity.orgSlug),
image: profile.image || "",
alt: profile.name || "",
title: profile.name || "",
},
]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only meant for org event types and not normal event types

@graphite-app Graphite App
Copy link

graphite-app bot commented May 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel DeploySentinel
Copy link

deploysentinel bot commented May 14, 2024 •
edited

Current Playwright Test Results Summary

✅ 8 Passing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/23/2024 04:16:44pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 40f2764

Started: 05/23/2024 04:15:12pm UTC

⚠️ Flakes

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Test preview should return correct route
Retry 1 • Initial Attempt
0.45% (1) 1 / 224 run
failed over last 7 days
33.93% (76) 76 / 224 runs
flaked over last 7 days

View Detailed Build Results

@zomars zomars enabled auto-merge (squash) May 14, 2024 18:58
@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 7:43am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 7:43am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview May 23, 2024 7:43am

zomars
zomars previously requested changes May 16, 2024
View reviewed changes
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're having merge conflicts now. @Udit-takkar Can you take a look?

@Udit-takkar Udit-takkar requested a review from zomars May 17, 2024 10:24
hariombalhara
hariombalhara previously requested changes May 22, 2024
View reviewed changes
Copy link
Member

@hariombalhara hariombalhara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a blocking comment otherwise it is good.

@hariombalhara
Copy link
Member

Approved but let's add a test for this in a follow-up

@zomars zomars merged commit 0cb2e60 into main May 23, 2024
42 checks passed
@zomars zomars deleted the fix/booking-page-url branch May 23, 2024 16:17
@ashi9ue ashi9ue mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariombalhara hariombalhara hariombalhara approved these changes

@emrysal emrysal Awaiting requested review from emrysal

@zomars zomars Awaiting requested review from zomars

Assignees
No one assigned
Labels
booking-page area: booking page, public booking page, booker 🐛 bug Something isn't working consumer core area: core, team members only High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.

[CAL-3702] Back to Homapage flow not working
4 participants
@Udit-takkar @hariombalhara @zomars @keithwillcode