Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed segfault in LLVM Orc example #1501

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fixed segfault in LLVM Orc example #1501

wants to merge 8 commits into from

Conversation

Minding000
Copy link

@Minding000 Minding000 commented May 16, 2024 •
edited

Issue

The LLVM ORC example segfaults when freeing error messages using LLVMConsumeError because LLVMGetErrorMessage already consumes the error.

Changes

  • Fixed error handling
  • Removed unnecessary initialization / function calls
  • Renamed Factorial example to MCJIT to highlight the difference between MCJIT and ORC
  • Added info that ORC is newer than MCJIT to the readme
  • Improved readability
  • Fixed typos

Notes

  • I tested all changes

saudet
saudet reviewed May 19, 2024
View reviewed changes
llvm/README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saudet saudet saudet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Minding000 @saudet