Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llvm build error #3446

Closed
wants to merge 1 commit into from

Conversation

byeongjee
Copy link
Contributor

Otherwise we get error: externally-managed-environment.

I'm not sure if this would be the best way to handle the issue, but we are already doing this anyway (in Dockerfile, for example).

Otherwise we get error: externally-managed-environment.
@wenyongh
Copy link
Contributor

Otherwise we get error: externally-managed-environment.

I'm not sure if this would be the best way to handle the issue, but we are already doing this anyway (in Dockerfile, for example).

Hi, what is the OS you used? We usually run build_llvm.sh in Ubuntu, MacOS and Windows and didn't find the issue. The --break-system-packages is added in Dockerfile and workflow since sometimes the OS in them is a little old, had better not add it to build_llvm.sh if not needed.

@yamt
Copy link
Collaborator

yamt commented May 20, 2024

Hi, what is the OS you used? We usually run build_llvm.sh in Ubuntu, MacOS and Windows and didn't find the issue.

on macOS i have seen the error.
i don't know the exact cause or the correct fix.
i usually just remove --user and use virtualenv.

@wenyongh
Copy link
Contributor

Hi, what is the OS you used? We usually run build_llvm.sh in Ubuntu, MacOS and Windows and didn't find the issue.

on macOS i have seen the error. i don't know the exact cause or the correct fix. i usually just remove --user and use virtualenv.

Yes, maybe we can just manually update the script and had better not add --break-system-packages for many files and commit them, not sure whether it will cause unexpected behavior.

@byeongjee
Copy link
Contributor Author

byeongjee commented May 21, 2024

Thanks for the explanation! Yes, I am using Mac 14.5, and it seems thatI this error only happens in newer versions of Python.
I'll close this PR for now.

@byeongjee byeongjee closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants