Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket metadata update, please read my comments in description #2515

Open
wants to merge 70 commits into
base: main
Choose a base branch
from

Conversation

KikiSpace
Copy link

My change is only at file
lib/wasm-micro-runtime/core/iwasm/interpreter/wasm_runtime.h
lib/wasm-micro-runtime/core/iwasm/libraries/libc-wasi/libc_wasi_wrapper.c

Notice there 146 files changes in this pull request so that mean some of change haven't been merge to main before. Please review changes in this files to make sure it is necessary. Thanks!

@wenyongh
Copy link
Contributor

My change is only at file lib/wasm-micro-runtime/core/iwasm/interpreter/wasm_runtime.h lib/wasm-micro-runtime/core/iwasm/libraries/libc-wasi/libc_wasi_wrapper.c

Notice there 146 files changes in this pull request so that mean some of change haven't been merge to main before. Please review changes in this files to make sure it is necessary. Thanks!

Could you just commit the changed files? No need to commit so many files.

@@ -9,6 +9,7 @@
*.a
*.so
.DS_Store
foo
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a local and private directory. right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants