Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace firefoxheadless.sh with soft kill #229

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BaerMitUmlaut
Copy link

@BaerMitUmlaut BaerMitUmlaut commented Oct 8, 2018

I'm still having a little trouble with running my build which might be related to using WSL (I can't run master either)... Will test again later on Linux.

@BaerMitUmlaut
Copy link
Author

It seems like previously the marionette was already gone and thus the quit command could not be sent, so I tried killing by PID. I also noticed that the firefoxheadless.sh is still needed because web-ext doesn't support a headless parameter.
One problem now is that the process is getting killed twice because of the deferred process kill. Maybe I can find a cleaner way.

@tombh
Copy link
Member

tombh commented Oct 26, 2018

Sorry for the delay. I've just been away from the codebase so long, I can't read this without running the code myself. So the only problem with it is for dev/test environments? Because of web-ext's reliance on firefoxheadless.sh? Maybe that's why the Travis build failed?

I wish I wasn't so long away from the code, then I could give you better advice. But thank you so much for contributing.

@tombh tombh force-pushed the master branch 4 times, most recently from f290601 to 81f41b7 Compare June 19, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firefoxheadless.sh kill fails on Mac Kill the headless Firefox process by PID, not by grepping ps
2 participants