Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Use Correct Deposit Icon on Accounts Page #23740

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Now uses the correct Deposit icon on the Accounts page.

Resolves brave/brave-browser#38403

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Accounts page
  2. Click on the More Menu for one of your accounts listed
  3. The Deposit icon should be Money Bags, not a QR Code.

Before:

Screenshot 52

After:

Screenshot 53

@Douglashdaniel Douglashdaniel self-assigned this May 18, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner May 18, 2024 04:31
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels May 18, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel merged commit f095fc5 into master May 20, 2024
20 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-use-correct-deposit-icon-on-accounts-page branch May 20, 2024 12:28
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone May 20, 2024
brave-builds added a commit that referenced this pull request May 20, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.68.39 Chromium: 125.0.6422.76 (Official Build) nightly (64-bit)
Revision 8d3c424
OS Linux
  • Verified steps from PR
  • Verified Deposit icon on Accounts page is Money bag and not `QR Code
  • Verified deposit icon is same on all screens
#23740-Account #23740-Portfolio #23740-Token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
4 participants