Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deposit icon should be same on all screens #38403

Closed
srirambv opened this issue May 17, 2024 · 2 comments · Fixed by brave/brave-core#23740
Closed

Deposit icon should be same on all screens #38403

srirambv opened this issue May 17, 2024 · 2 comments · Fixed by brave/brave-core#23740
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Follow up to38077, Deposit icon should be same on all screens

Steps to Reproduce

  1. Same as 38077

Actual result:

Deposit icon is QR code

Expected result:

Deposit icon should be money bag

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.67.85 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
Revision d01060f5ec155e6eb64a335203663a29c0e5d81f
OS Windows 11 Version 23H2 (Build 22631.3593)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel

@kjozwiak
Copy link
Member

The above requires 1.67.93 or higher for 1.67.x verification 👍

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.67.94 Chromium: 125.0.6422.112 (Official Build) beta (64-bit)
Revision 3e4d210c91412b82ad8cffca556b12bbe40ff962
OS Windows 11 Version 23H2 (Build 22631.3593)
38403.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants