Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable in app update dialog for < android 14 devices #23727

Merged
merged 2 commits into from
May 23, 2024
Merged

Enable in app update dialog for < android 14 devices #23727

merged 2 commits into from
May 23, 2024

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented May 17, 2024 •
edited

Resolves brave/brave-browser#38394

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please reach out to @deeppandya more details.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels May 17, 2024
@deeppandya deeppandya added this to the 1.68.x - Nightly milestone May 17, 2024
@deeppandya deeppandya self-assigned this May 17, 2024
samartnik
samartnik approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya force-pushed the in_app_update_android_13_and_below branch from 95a92c5 to 2d2d8a6 Compare May 22, 2024 20:23
@deeppandya deeppandya force-pushed the in_app_update_android_13_and_below branch from 2d2d8a6 to cb56a5b Compare May 23, 2024 03:40
@deeppandya deeppandya enabled auto-merge May 23, 2024 03:41
@deeppandya deeppandya merged commit 92dfc0d into master May 23, 2024
19 checks passed
@deeppandya deeppandya deleted the in_app_update_android_13_and_below branch May 23, 2024 05:18
brave-builds added a commit that referenced this pull request May 23, 2024
@brave-builds
Uplift of #23727 (squashed) to beta
8a59e0d
@brave-builds brave-builds mentioned this pull request May 23, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024 •
edited

Android 12 verification

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.68.79 Chromium: 126.0.6478.40 (Official Build) canary (64-bit)
-- | --
Revision | c1824205ec7555cab92753929275bb7beae4e73b
OS | Android 12; Build/SP1A.210812.016; 31; REL

Test Case #1 - Basic Update/Dismissing toast several times (functionality check)

  • install/launch 1.68.41 Chromium 125.0.6422.76 and ensure there's no GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead ~a week (should be a month ahead)
  • once you're a month ahead, ensure that you receive a GPS modal that indicates there's a new update via the GPS
  • ensure that clicking on Learn more opens Brave Browser (Nightly) via the GPS
  • click on Update and ensure that you eventually receive a Update toast at the bottom of the current tab/page
  • ensure that there's a pending Nightly update available via GPS before clicking on Update via the GPS modal
  • sometimes this can take ~1-2mins depending on the GPS (easiest way is to check GPS to see if Brave is being updated)
  • ensure that the Update toast that appears at the bottom of the page is dismissed after a few seconds
  • ensure that the Update toast appears anytime you restart Brave
    • ensure that once dismissed, it doesn't appear for that session unless Brave is restarted
  • ensure that clicking on Update installs/relaunches Brave without any issues

Example of the feature being used --> https://youtu.be/AdN7g4AOKYg

GPS Modal/Clicking on Learn More

Example Example Example
Screenshot_20240709-011930_Google Play Store Screenshot_20240709-011944_Android System Screenshot_20240709-011952_Google Play Store

Toast/Installing`

Example Example
Screenshot_20240709-012649_Brave - Nightly Screenshot_20240709-012655_Google Play Store

Test Case #2 - Dismissing GPS Modal

  • install/launch 1.68.41 Chromium 125.0.6422.76 and ensure there's no GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead ~a week (should be a month ahead)
  • once you're a month ahead, ensure that you receive a GPS modal that indicates there's a new update via the GPS
  • dismiss the GPS modal by pressing on X
  • ensure that you don't see the GPS modal after restarting Brave several times (will be displayed in another month)
  • close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
  • once you're a another month ahead, ensure that you receive a GPS modal that indicates there's a new update via the GPS
Screen_Recording_20240810_015454_Settings.mp4

Android 14 verification

Verification PASSED on Pixel 6 running Android 14 using the following build(s):

Brave | 1.68.41 Chromium: 125.0.6422.76 (Official Build) canary (64-bit)
--- | ---
Revision | f788cc73b5c571ea196bd6d4495cad0c3e81bf08
OS | Android 14; Build/AP21.240305.006; 34; REL
  • install/launch 1.68.41 Chromium 125.0.6422.76 and ensure there's no GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
  • close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
  • close Brave and move system clock ahead ~a week (should be a month ahead)
  • ensured that the GPS modal doesn't appear on Android 14 devices

Example --> https://youtu.be/EKtFRnBK9sE

kjozwiak pushed a commit that referenced this pull request Jun 7, 2024
@brave-builds
Enable in app update dialog for < android 14 devices (uplift to 1.67.…
0161336 
…x) (#23809)

Uplift of #23727 (squashed) to beta
@kjozwiak kjozwiak mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samartnik samartnik samartnik approved these changes

@tapanmodh tapanmodh Awaiting requested review from tapanmodh

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.68.x - Beta
3 participants
@deeppandya @kjozwiak @samartnik