Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable in app update dialog < android 14 #38394

Closed
deeppandya opened this issue May 17, 2024 · 2 comments · Fixed by brave/brave-core#23727
Closed

[Android] Enable in app update dialog < android 14 #38394

deeppandya opened this issue May 17, 2024 · 2 comments · Fixed by brave/brave-core#23727
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/updater OS/Android Fixes related to Android browser functionality QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@deeppandya
Copy link

As a follow up to #38034, we need to enable in app update dialog for < android 14 devices.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024

The above requires 1.67.109 or higher for 1.67.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024

@hffvld @Uni-verse can use brave/brave-core#23727 (comment) as a general template. Some info to keep in mind when running through the above:

  • the GPS modal will appear once a month
  • the Update toast at the bottom of the page will appear once per sessions once the update is ready/staged
  • keep in mind if you move too ahead, sometimes updates won't work due to the device being ahead in time
    • certain websites will also stop working due to the device being to ahead

While we're running through the above, we should also verify that updating with the above way doesn't cause any issues re: losing state. Please run through an upgrade like we usually do but running through the above method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/updater OS/Android Fixes related to Android browser functionality QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants