[PM-8254] Create shareable export component #9246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9246 +/- ##
=======================================
Coverage 28.15% 28.15%
=======================================
Files 2375 2375
Lines 70222 70222
Branches 13173 13173
=======================================
Hits 19773 19773
Misses 48884 48884
Partials 1565 1565 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Base automatically changed from
tools/pm-8252/use-new-userverification-for-exports-on-all-clients
to
main
May 21, 2024 11:02
djsmith85
requested review from
vincentsalucci
and removed request for
a team and
vincentsalucci
Fix lint issue with takeUntil
Copied existing export.component.html as that has already been migrated to use the component library components Strip the markup from the dialog and the submit-button
…mit, loading, disabled) Emit successful Export Expose a form-id so the hosting component can bind to this form Fix name of output
…dVault is collected
djsmith85
force-pushed
the
tools/pm-8254/create-shareable-export-component
branch
from
1423391
to
1378eb4
Compare
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Outdated
Show resolved
Hide resolved
audrey-jensen
previously approved these changes
May 21, 2024
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Outdated
Show resolved
Hide resolved
Comment on lines
166
to
173
| this.bitSubmit.loading$.pipe(takeUntil(this.destroy$)).subscribe((loading) => { | ||
| this.formLoading.emit(loading); | ||
| }); | ||
|
|
||
| this.bitSubmit.disabled$.pipe(takeUntil(this.destroy$)).subscribe((disabled) => { | ||
| this.formDisabled.emit(disabled); | ||
| }); | ||
| } |
There was a problem hiding this comment.
🎨 EventEmitter<T> implements Subject<T>. You should be able to subscribe to it directly:
this.bitSubmit.loading$
.pipe(takeUntil(this.destroy$))
.subscribe(this.formLoading);
this.bitSubmit.disabled$
.pipe(takeUntil(this.destroy$))
.subscribe(this.formDisabled);
audrey-jensen
previously approved these changes
May 21, 2024
libs/tools/export/vault-export/vault-export-ui/src/components/export.component.ts
Outdated
Show resolved
Hide resolved
audrey-jensen
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Code changes
Before you submit