[PM-8252] Use new user-verification for exports on all clients #9244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ExportComponent Add "@bitwarden/auth" as dependency to the vault-export-ui package New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop
…he new UI is opened as a self-contained dialog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9244 +/- ##
==========================================
+ Coverage 28.07% 28.09% +0.01%
==========================================
Files 2435 2435
Lines 70528 70491 -37
Branches 13143 13130 -13
==========================================
Hits 19804 19804
+ Misses 49185 49148 -37
Partials 1539 1539 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
r-tome
approved these changes
May 20, 2024
djsmith85
deleted the
tools/pm-8252/use-new-userverification-for-exports-on-all-clients
branch
quexten
pushed a commit
that referenced
this pull request
May 22, 2024
* Move/replace submit and userVerification logic from web into the BaseExportComponent Add "@bitwarden/auth" as dependency to the vault-export-ui package New submit logic also checks for password-encrypted exports which will be need for future UI updates on browser and desktop * Remove import/passing of the unneeded UserVerificationService * Remove app-user-verification from browser and desktop components as the new UI is opened as a self-contained dialog --------- Co-authored-by: Daniel James Smith <djsmith85@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
On the web we use the new
UserVerificationDialogComponentwhich supports additional verification methods besides a user’s master password.This possibility is currently missing on browser and desktop, which fails for user’s that login with for example a
passkeyorLogin with DeviceThis also pays forward on the initiative to create a shareable export component which can be used across clients which would also enable password-encrypted exports to browser and desktop.
Code changes
Screenshots
Before
After
Before you submit