Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CL-290] make popup layout grow to full height #9237

Merged
merged 3 commits into from
May 20, 2024

Conversation

willmartian
Copy link
Contributor

@willmartian willmartian commented May 17, 2024

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

The extension layout component should grow to fill 100% of the available height. Otherwise, devs will be unable to vertically center page content. See: #9199 (comment)

Code changes

  • apps/browser/src/platform/popup/layout/popup-layout.stories.ts: Add story
  • apps/browser/src/platform/popup/layout/popup-page.component.html: propogate tw-h-full down element tree

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.08%. Comparing base (121494f) to head (dadbc73).
Report is 16 commits behind head on main.

Files Patch % Lines
.../src/platform/popup/layout/popup-layout.stories.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9237      +/-   ##
==========================================
- Coverage   28.12%   28.08%   -0.05%     
==========================================
  Files        2436     2435       -1     
  Lines       70494    70532      +38     
  Branches    13136    13143       +7     
==========================================
- Hits        19829    19811      -18     
- Misses      49130    49182      +52     
- Partials     1535     1539       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as off-topic.

@willmartian willmartian removed the needs-qa Marks a PR as requiring QA approval label May 17, 2024
@willmartian willmartian marked this pull request as ready for review May 17, 2024 17:37
@willmartian willmartian requested a review from a team as a code owner May 17, 2024 17:37
@willmartian willmartian requested a review from coroiu May 17, 2024 17:37
@willmartian willmartian enabled auto-merge (squash) May 17, 2024 17:42
Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@willmartian willmartian merged commit 034227d into main May 20, 2024
24 of 25 checks passed
@willmartian willmartian deleted the ps/CL-290/popup-layout-full-height branch May 20, 2024 11:38
quexten pushed a commit that referenced this pull request May 22, 2024
* add tw-h-full to popup layout template

* add story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants