[AC-2605] Restrict collection access for some custom users

[eliykat]

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Currently, the Allow admin access to all collections and items setting does not affect Custom Users with the Manage Groups or Manage Users permissions - they can assign groups and users (respectively) to any collection, including those they don't manage.

Update their permission check to only allow this if Allow admin access is enabled - or if the feature flag is off entirely (current behavior). Otherwise, they must have Can Manage permissions like everyone else. This aligns them with how admins and owners are treated.

Server PR: bitwarden/server#4096

Code changes

• file.ext: Description of what was changed and why

Screenshots

Screen.Recording.2024-05-17.at.1.38.42.PM.mov

Before you submit

• Please add unit tests where it makes sense to do so (encouraged but not required)
• If this change requires a documentation update - notify the documentation team
• If this change has particular deployment requirements - notify the DevOps team
• Ensure that all UI additions follow WCAG AA requirements

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 28.12%. Comparing base (a7406ab) to head (8c238d0).

Files	Patch %	Lines
.../src/app/vault/core/views/collection-admin.view.ts	0.00%	6 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9231   +/-   ##
=======================================
  Coverage   28.11%   28.12%           
=======================================
  Files        2361     2361           
  Lines       69859    69863    +4     
  Branches    13142    13144    +2     
=======================================
+ Hits        19644    19648    +4     
  Misses      48659    48659           
  Partials     1556     1556           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Checkmarx One – Scan Summary & Details – 908e7e79-6a60-45e3-b901-c8d6dc18b4d0

No New Or Fixed Issues Found