Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5157] Rename view elements for Duo Universal #9224

Merged
merged 2 commits into from
May 20, 2024

Conversation

ike-kottlowski
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Rename visual elements to match Duo Universal verbiage. There is no update to the request/response communication with the API.

Code changes

  • two-factor-duo.component.html/ts: renamed presentational properties to match Duo Universal verbiage.
  • messages.json: added items for new verbiage.

Screenshots

Set dialog

msedge_f4NMC8XK41

View dialog

msedge_1bgkQIkNGC

Login flow

pm-5157-duo-login.-.Made.with.Clipchamp.mp4

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@ike-kottlowski ike-kottlowski requested a review from a team as a code owner May 16, 2024 23:47
@ike-kottlowski ike-kottlowski requested a review from rr-bw May 16, 2024 23:47
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 28.09%. Comparing base (96f2b4d) to head (ab39b0f).

Files Patch % Lines
.../src/app/auth/settings/two-factor-duo.component.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9224   +/-   ##
=======================================
  Coverage   28.08%   28.09%           
=======================================
  Files        2435     2435           
  Lines       70526    70526           
  Branches    13143    13143           
=======================================
+ Hits        19804    19811    +7     
+ Misses      49183    49176    -7     
  Partials     1539     1539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 17, 2024

Logo
Checkmarx One – Scan Summary & Details52a31d74-3a01-4b87-ad1c-028e89e047c4

No New Or Fixed Issues Found

@ike-kottlowski ike-kottlowski removed the needs-qa Marks a PR as requiring QA approval label May 17, 2024
@ike-kottlowski ike-kottlowski merged commit d3426e7 into main May 20, 2024
34 of 35 checks passed
@ike-kottlowski ike-kottlowski deleted the auth/pm-5157/duo-param-rename branch May 20, 2024 14:28
quexten pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants