[PM-8517] Create web specific layout #9209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hinton
commented
May 16, 2024
bitwarden_license/bit-web/src/app/secrets-manager/layout/layout.component.html
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9209 +/- ##
=======================================
Coverage 28.18% 28.18%
=======================================
Files 2397 2398 +1
Lines 70642 70637 -5
Branches 13203 13201 -2
=======================================
+ Hits 19910 19911 +1
+ Misses 49172 49167 -5
+ Partials 1560 1559 -1 ☔ View full report in Codecov by Sentry. |
willmartian
approved these changes
May 16, 2024
| import { ToggleWidthComponent } from "./toggle-width.component"; | ||
|
|
||
| @Component({ | ||
| selector: "app-layout", |
There was a problem hiding this comment.
Thoughts on selector: "web-layout"?
There was a problem hiding this comment.
I was debating back and forth, we generally use app but I agree web would be nicer ...
|
No New Or Fixed Issues Found |
Hinton
changed the title
Thomas-Avery
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We currently duplicate some logic between our layouts. In an effort to streamline our experience I'm exploring if we can create a web specific layout that handles some of this.
Before you submit