Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-8045 All Subscription plans can be selected same time #9185

Merged
merged 1 commit into from
May 20, 2024
Merged

PM-8045 All Subscription plans can be selected same time #9185

merged 1 commit into from
May 20, 2024

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Currently all subscription plans can be selected at the same time, should make it only one selectable at a time.

Code changes

  • organization-plans.component.html: Changed the *ngFor directive to be inside radio button group.

Screenshots

Subscription._.Bitwarden.Web.vault.-.Google.Chrome.2024-05-15.11-40-34.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner May 15, 2024 06:11
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 487ef293-c697-4206-ab70-1cf3aeccd28a

No New Or Fixed Issues Found

cyprain-okeke
cyprain-okeke approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@cyprain-okeke cyprain-okeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@KiruthigaManivannan KiruthigaManivannan merged commit a7406ab into main May 20, 2024
35 checks passed
@KiruthigaManivannan KiruthigaManivannan deleted the PM-8045-defect-all-subscription-plans-can-be-selected-at-the-same-time branch May 20, 2024 22:24
quexten pushed a commit that referenced this pull request May 22, 2024
@KiruthigaManivannan @quexten
PM-8045 All Subscription plans can be selected same time (#9185)
fbbba74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyprain-okeke cyprain-okeke cyprain-okeke approved these changes

Assignees
No one assigned
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KiruthigaManivannan @cyprain-okeke