Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1938 Migrate Accept Emergency Component #9177

Merged
merged 16 commits into from
Jun 6, 2024

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Migrate the Accept Emergency Component to use the component library.

Code changes

  • accept-emergency.component.html: Added buttons from library
  • oss-routing.module.ts: Added Routing for Anon layout wrapper component.

Screenshots

Emergency.access._.Bitwarden.Web.vault.-.Google.Chrome.2024-05-14.20-54-08.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner May 14, 2024 15:35
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d8a86cd). Learn more about missing BASE report.

Files Patch % Lines
apps/web/src/app/oss-routing.module.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9177   +/-   ##
=======================================
  Coverage        ?   28.16%           
=======================================
  Files           ?     2431           
  Lines           ?    71538           
  Branches        ?    13372           
=======================================
  Hits            ?    20151           
  Misses          ?    49798           
  Partials        ?     1589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

Logo
Checkmarx One – Scan Summary & Details9fd3477a-cbbe-4761-b166-f9789bef4e5c

No New Or Fixed Issues Found

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating the feedback! Looks good to me!

…t-emergency-component + resolved merge conflict in oss-routing.module.
@KiruthigaManivannan KiruthigaManivannan merged commit f2bd16a into main Jun 6, 2024
33 of 34 checks passed
@KiruthigaManivannan KiruthigaManivannan deleted the PM-1938-migrate-accept-emergency-component branch June 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants