Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-4960 Migrate Verify Recover Delete Component #9171

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Migrate the Verify Recover Delete Component to use the component library.

Code changes

  • verify-recover-delete.component.html: Added form group and bit form fields
  • verify-recover-delete.component.ts: Added new form group , converted submit to arrow function
  • oss-routing.module.ts: Added Routing for Anon layout wrapper component.

Screenshots

Verify.Recover.Delete.-.Google.Chrome.2024-05-14.18-10-28.mp4
Verify.Recover.Delete.-.Google.Chrome.2024-05-14.18-10-28.mp4
Verify.Recover.Delete.-.Google.Chrome.2024-05-14.18-10-28.mp4

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.18%. Comparing base (d30b947) to head (85ed42d).

Files Patch % Lines
...eb/src/app/auth/verify-recover-delete.component.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9171   +/-   ##
=======================================
  Coverage   28.18%   28.18%           
=======================================
  Files        2434     2434           
  Lines       71663    71661    -2     
  Branches    13394    13393    -1     
=======================================
  Hits        20195    20195           
+ Misses      49875    49874    -1     
+ Partials     1593     1592    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

Logo
Checkmarx One – Scan Summary & Details4b157455-09fb-47d2-a3fd-033764afc869

New Issues

Severity Issue Source File / Package Checkmarx Insight
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/base-program.ts: [102](https://github.com/bitwarden/clients/blob/PM-4960-migrate-verify-recover-delete-component//apps/cli/src/base-program.ts# L102) Attack Vector

…960-migrate-verify-recover-delete-component
Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functional tests were good.

ike-kottlowski
ike-kottlowski previously approved these changes May 29, 2024
Copy link
Contributor

@ike-kottlowski ike-kottlowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rr-bw rr-bw removed their request for review May 30, 2024 16:44
…960-migrate-verify-recover-delete-component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants