PM-4951 Migrate Recover Two Factor Component #9170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9170 +/- ##
=======================================
Coverage 28.16% 28.17%
=======================================
Files 2432 2432
Lines 71554 71557 +3
Branches 13376 13375 -1
=======================================
+ Hits 20151 20158 +7
+ Misses 49813 49810 -3
+ Partials 1590 1589 -1 ☔ View full report in Codecov by Sentry. |
rr-bw
requested changes
May 15, 2024
…951-migrate-recover-two-factor-component
rr-bw
requested changes
May 22, 2024
…951-migrate-recover-two-factor-component
rr-bw
requested changes
Jun 3, 2024
There was a problem hiding this comment.
For this page:
- Grab latest from
main - Update the import in
oss-routing.module.tsto:
import { AnonLayoutWrapperComponent } from "@bitwarden/auth/angular";- Update the route to:
{
path: "",
component: AnonLayoutWrapperComponent,
children: [
{
path: "recover-2fa",
canActivate: [unauthGuardFn()],
children: [
{
path: "",
component: RecoverTwoFactorComponent,
},
{
path: "",
component: EnvironmentSelectorComponent,
outlet: "environment-selector",
},
],
data: {
pageTitle: "recoverAccountTwoStep",
titleId: "recoverAccountTwoStep",
},
},
],
},You will need to import the web Environment Selector:
import { EnvironmentSelectorComponent } from "./components/environment-selector/environment-selector.component";
rr-bw
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Migrate the Recover Two Factor Component to use the component library.
Code changes
Screenshots
Recover.Two.Factor.-.Google.Chrome.2024-05-14.15-29-48.mp4