Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM-1943 Migrate Recover Delete Component #9169

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

KiruthigaManivannan
Copy link
Collaborator

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [x] Other

Objective

Migrate the Recover Delete Component to use the component library.

Code changes

  • recover-delete.component.html: Added form group and bit form fields
  • recover-delete.component.ts: Added new form group , converted submit to arrow function
  • oss-routing.module.ts: Added Routing for Anon layout wrapper component.

Screenshots

Recover_Delete-.Google.Chrome.2024-05-14.14-43-55.mp4

@KiruthigaManivannan KiruthigaManivannan requested a review from a team as a code owner May 14, 2024 09:15
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 28.17%. Comparing base (d3f1992) to head (a8d92c0).
Report is 1 commits behind head on main.

Files Patch % Lines
apps/web/src/app/auth/recover-delete.component.ts 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9169      +/-   ##
==========================================
+ Coverage   28.16%   28.17%   +0.01%     
==========================================
  Files        2431     2431              
  Lines       71552    71550       -2     
  Branches    13375    13374       -1     
==========================================
+ Hits        20151    20158       +7     
+ Misses      49812    49804       -8     
+ Partials     1589     1588       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 14, 2024

Logo
Checkmarx One – Scan Summary & Details5acba3ce-ed0f-4735-9ab7-0d57a8332392

No New Or Fixed Issues Found

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! Just two minor tweaks!

apps/web/src/app/auth/recover-delete.component.ts Outdated Show resolved Hide resolved
apps/web/src/app/oss-routing.module.ts Outdated Show resolved Hide resolved
…er-delete-component + fix merge conflicts + consolidate routes under single anon layout wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants