check service flags being supported by dns providers #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laanwj
reviewed
Apr 23, 2024
|
This should imo be an optional command-line flag. This script is primarily meant as a quick health check for the DNS seeds. Adding the service bit scanning funcionality could be useful, but i don't think it should be on by default. |
naiyoma
force-pushed
the
feature/filter-dns-seeds
branch
from
f1dcb9f
to
65bcdc5
Compare
Nice Suggestion, Ive pushed an update to make |
gatleas17
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, comments for DNS seed filtering are not updated, as discussed here and here. Opening a pull request to update the comments can be noisy. Therefore, I have modified this script to generate all possible combinations of service flags along with their corresponding hexadecimal values and include a function to check if a DNS provider supports a given combination of node services.
My proposal is to add a comment referencing this script to ensure all filters are obtained