-
-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orange Table-specific HDF5Reader #6791
base: master
Are you sure you want to change the base?
Conversation
In fixing this, switched string handling from fixed-length to variable length https://docs.h5py.org/en/stable/special.html#variable-length-strings
Orange/data/io.py
Outdated
return f[name] | ||
return None | ||
|
||
assert 'domain' in f |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be better to put some attribute in the HDF5 to explicitly identify it as coming from Orange (could also specify which version) rather than just sniffing for "domain". This would improve discoverability, which is always an issue for HDF5 files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, absolutely. We should have an ID field and probably also a version identifier. Do you know how HDF5 files usually do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some attributes to the root following the NeXus convention (creator, Orange_version, HDF5_Version, h5py_version) Weird capitalization of "HDF5_Version" is apparently intentional.
I couldn't find a satisfactory solution to the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6791 +/- ##
=======================================
Coverage 88.20% 88.21%
=======================================
Files 327 327
Lines 71223 71301 +78
=======================================
+ Hits 62825 62900 +75
- Misses 8398 8401 +3 |
Comments from @stuart-cls (from his email, just so that they do not get lost):
|
Issue
Enable saving/loading the Orange Table data structure from the binary HDF5 container.
Based on the implementation used in the dask branch, but with the dask parts removed.
Related: #6356
Description of changes
HDF5Reader
with bothread
andwrite_file
methods.h5py
to requirements.metadata
sidecar file to storetable.attributes
if present.Includes