Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repaints causing ThrowInfiniteSeparators. #1514

Merged
merged 3 commits into from
May 23, 2024

Conversation

mvphelps
Copy link

Also include axis name in exception if available.

This is in response to issue #1495. Avalonia apps can cause repaints, even on charts not visible in the UI. Since Invalidate() is bypassed in this case, _stepCount would increment and eventually throw. This PR removes _stepCount and makes the check for the number of separators within EnumerateSeparators, and still throws the same exception if exceeded.

Additionally to help users troubleshoot, if the Axis has a name, the exception now includes the name in the message. I can remove this if desired, in the event of users checking the contents of the message, this could represent an API change effectively.

@mvphelps
Copy link
Author

For resolving NETSDK1202: https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1202
Seems we need to add that. Given I'm not the maintainer, would like your input on this. But totally willing to add it, not a big deal.

Not sure what do do about NETSDK1147. Does the build just fail to install workloads sometimes?

@beto-rodriguez
Copy link
Owner

Thanks for the PR, I will check this.

Not sure what do do about NETSDK1147. Does the build just fail to install workloads sometimes?

Probably the environment where Github actions are running was updated, I also need to check that.

@mvphelps
Copy link
Author

mvphelps commented May 22, 2024

@beto-rodriguez I see LiveChartsCore is using the various workloads for the Target framework property. I've moved the workload installation up in the build-windows.ps1 script to prior to any compilation, since all projects had failed.

@beto-rodriguez beto-rodriguez changed the base branch from master to dev May 23, 2024 17:32
@beto-rodriguez
Copy link
Owner

beto-rodriguez commented May 23, 2024

This fix is definitively necessary and fixes the issue.

About the CI task, there are some projects that require a specific min version of visual studio (WinUI and Uno at least), since I do not have control over which version is installed in the Github actions environment, I skipped those builds for now.

I will merge as soon the test pass.

@beto-rodriguez
Copy link
Owner

beto-rodriguez commented May 23, 2024

Tests passed, some projects are not compiling... probably Maui also requires a min visual studio version, I will check that and fix it in another PR.

@beto-rodriguez beto-rodriguez merged commit 41439a5 into beto-rodriguez:dev May 23, 2024
2 of 4 checks passed
@mvphelps
Copy link
Author

That's great @beto-rodriguez thank you. I will definitely contribute to your project again if I find need in the future. You are easy to collaborate with!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants