Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Describe default Behaviour of branch filter in the Configuration of the Github discovery provider. #24790

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

J0shSkqlq
Copy link
Contributor

@J0shSkqlq J0shSkqlq commented May 15, 2024

Hey, I just made a Pull Request!

I just added a small hint in the docs about the default behaviour of the branch filter in the Configuration of the Github discovery provider. I myself assumed that not configuring a filter would lead to the discovery processor checking all branches for a catalog info file, so adding this will hopefully help others.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • All your commits have a Signed-off-by line in the message. (more info)

…cs))

I would have expected the Discovery Processor to look at all branches. Having this hint would be nice.

Signed-off-by: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com>
I would have expected the Discovery Processor to look at all branches. Having this hint would be nice.

Signed-off-by: J0shSkqlq <103205739+J0shSkqlq@users.noreply.github.com>
@J0shSkqlq J0shSkqlq requested review from a team as code owners May 15, 2024 12:05
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 15, 2024
Copy link
Member

@freben freben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@freben freben merged commit 71f97dd into backstage:master Jun 4, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants