-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: CFITSIO 4.4.0 #16456
base: main
Are you sure you want to change the base?
DEP: CFITSIO 4.4.0 #16456
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olebole, do you know what Debian thinks of this license?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eteq is passionate about license too, so also pinging him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This license is approved by OSI: https://opensource.org/license/nasa1-3-php, but Debian sees it as not compliant to its guidelines: https://lists.debian.org/debian-legal/2011/04/msg00075.html.
I would prefer to have this rejected; specifically because there is no functional change at all. I am not sure whether the Debian cfitsio maintainer had a discussion with upstream yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱
Do you think CFITSIO would get rid of this license in the next release? Given that it is distributed by NASA (https://heasarc.gsfc.nasa.gov/fitsio/), seems unlikely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell 4.4.0 is the first release under the new license, so bundling 4.3.1 should be uncontroversial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked our Debian maintainer Aurelien Jarno about wether he already contacted upstream (cc to our list). For me the license compliance situation is a bit unclearer: originally it was set as "non-compliant", but the mentioned mail thread questions this (without a definitive outcome IMO). Let's see what he says and whether we could/should contact upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, I am speaking with upstream and with my management at NASA to find out more about this.
Description
This pull request is to bump to CFITSIO 4.4.0. No functional changes to
astropy
, theoretically, so no need for change log.