Cythonize checking out of bounds latitudes

[maxnoe]

Description

Essentially the same as #16326 but for the out of limits checking in Latitude;

Profiling Latitude(angle) for different shapes / number of nans in the array before and after:

Fixes #

• By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[pllim]

The CI failure here looks related:

E ValueError: Big-endian buffer not supported on little-endian compiler

[maxnoe]

Ah, outside the coordinates package... I only ran the tests of astropy.coordinates

[maxnoe]

The FITS tests are relatively easy, endianness needs to be switched / big endian supported on little endian cpu.

However, I am more confused about the uncertainty tests.

How could I convinve this object to let me see its data as a simple 1d array:

<LatitudeDistribution [[-7.85398119e-01, -7.85398184e-01, -7.85398242e-01,
            -7.85398269e-01, -7.85398256e-01, -7.85398208e-01,
            -7.85398142e-01, -7.85398085e-01, -7.85398058e-01,
            -7.85398071e-01],
           [ 4.41180343e-08, -2.10160635e-08, -7.81227393e-08,
            -1.05389184e-07, -9.24005425e-08, -4.41180343e-08,
             2.10160635e-08,  7.81227393e-08,  1.05389184e-07,
             9.24005425e-08],
           [ 7.85398208e-01,  7.85398142e-01,  7.85398085e-01,
             7.85398058e-01,  7.85398071e-01,  7.85398119e-01,
             7.85398184e-01,  7.85398242e-01,  7.85398269e-01,
             7.85398256e-01]] rad with n_samples=10>

[astrofrog]

As there is this and also the wrapping cython function, I think we should only have one cython file for astropy.coordinates, because there is quite an overhead in terms of number of lines of code for each Cython file which slows down compilation.

[maxnoe]

@astrofrog Ok, I'll rebase the second PR to use a single cython file once one is merged

[neutrinoceros]

@maxnoe which one should we prioritize in reviewing ?

[maxnoe]

Let's do #16326 first

[neutrinoceros]

Gotcha. Can you make this one a draft then ?