Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new CLI param to save animations taking into account subtabs and repeats #4470

Merged
merged 2 commits into from
May 28, 2024

Conversation

martincapello
Copy link
Member

Fix #4297

@martincapello martincapello requested a review from dacap as a code owner May 13, 2024 21:02
@martincapello martincapello marked this pull request as draft May 13, 2024 21:04
@martincapello
Copy link
Member Author

Will add some tests

Copy link
Collaborator

@aseprite-bot aseprite-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -494,28 +494,27 @@ void SaveFileCopyAsCommand::onExecute(Context* context)

{
RestoreVisibleLayers layersVisibility;
Site site = context->activeSite();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: variable 'site' of type 'Site' can be declared 'const' [misc-const-correctness]

Suggested change
Site site = context->activeSite();
Site const site = context->activeSite();

@martincapello martincapello marked this pull request as ready for review May 14, 2024 19:16
@martincapello martincapello force-pushed the cli-save-using-subtags-repeats branch from 2704789 to 6c6a6e3 Compare May 15, 2024 20:16
@dacap dacap merged commit 24e72a3 into aseprite:main May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export tags issues
3 participants