Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crashing segfault when calling: app.command.CloseFile() or app.command.GotoPreviousTab() , in --batch mode (fix #4352) #4421

Merged
merged 1 commit into from
May 28, 2024

Conversation

Gasparoken
Copy link
Member

fix #4352

@Gasparoken Gasparoken self-assigned this Apr 17, 2024
@Gasparoken Gasparoken requested a review from dacap as a code owner April 17, 2024 18:19
@aseprite-bot
Copy link
Collaborator

clang-tidy review says "All clean, LGTM! 👍"

@Gasparoken Gasparoken assigned dacap and unassigned Gasparoken Apr 17, 2024
@dacap
Copy link
Member

dacap commented May 28, 2024

I'll merge this as it is because it fixes #4352. As a future task we'll have to implement these commands for batch processing but it's unrelated to this fix 👍 and it needs a kind of refactor (probably several commands should be handled by the app::Context and the app::UIContext override the behavior to deal with the Workspace, but for batch using a simpler default implementation).

@dacap dacap merged commit 1896483 into aseprite:main May 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing segfault when calling: app.command.CloseFile() or app.command.GotoPreviousTab() , in --batch mode
3 participants