Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on Pipeline.dry_run without parameters #655

Merged
merged 5 commits into from
May 22, 2024
Merged

Fix error on Pipeline.dry_run without parameters #655

merged 5 commits into from
May 22, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented May 21, 2024

Description

This PR fixes a bug (thanks @sdiazlor) that prevented calling dry_run method without parameters argument informed.

@plaguss plaguss added the fix label May 21, 2024
@plaguss plaguss self-assigned this May 21, 2024
alvarobartt
alvarobartt approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug report @sdiazlor and for the quick fix @plaguss 🤗

@alvarobartt alvarobartt linked an issue May 21, 2024 that may be closed by this pull request
[BUG] dry_run require parameters #653
Closed
sdiazlor
sdiazlor approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@sdiazlor sdiazlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@alvarobartt alvarobartt merged commit a0c9a41 into main May 22, 2024
4 checks passed
@alvarobartt alvarobartt deleted the fix-dry-run branch May 22, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarobartt alvarobartt alvarobartt approved these changes

@sdiazlor sdiazlor sdiazlor approved these changes

@gabrielmbmb gabrielmbmb Awaiting requested review from gabrielmbmb

Assignees

@plaguss plaguss

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] dry_run require parameters
3 participants
@plaguss @alvarobartt @sdiazlor