Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] dry_run require parameters #653

Closed
sdiazlor opened this issue May 21, 2024 · 1 comment · Fixed by #655
Closed

[BUG] dry_run require parameters #653

sdiazlor opened this issue May 21, 2024 · 1 comment · Fixed by #655
Assignees
Labels
bug Something isn't working

Comments

@sdiazlor
Copy link
Contributor

Describe the bug
If I'm not wrong I can pipeline.dry_run without any parameter as in pipeline.run. However, this is not allowed.

To Reproduce
Code to reproduce

with Pipeline(name="mistral-pipe", description="A pipeline to generate and score a distiset") as pipeline:

    load_dataset = LoadDataFromDicts(
        name= "load_dataset", data=[{"input": "test"}],
    )
distiset = pipeline.dry_run()

Expected behaviour
A clear and concise description of what you expected to happen.

Screenshots
image
image
image

Desktop (please complete the following information):

  • Package version: 1.1.0
  • Python version: Python 3.10.12

Additional context
Add any other context about the problem here.

@sdiazlor sdiazlor added the bug Something isn't working label May 21, 2024
@plaguss plaguss self-assigned this May 21, 2024
@plaguss
Copy link
Contributor

plaguss commented May 21, 2024

Thanks for reporting @sdiazlor, will tackle this later today.

@alvarobartt alvarobartt modified the milestone: 1.2.0 May 21, 2024
@alvarobartt alvarobartt linked a pull request May 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants