Make MetricsFeature's dependencies explicit #20945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
force-pushed
the
chore/dependency-cleanup-p2
branch
from
33fcbb4
to
0799185
Compare
goedderz
changed the title
alexbakharew
reviewed
Jun 3, 2024
Comment on lines
+391
to
+398
| void MetricsFeature::prepare() { | ||
| _queryRegistryFeature = std::move(_lazyQueryRegistryFeatureRef).get(); | ||
| _statisticsFeature = std::move(_lazyStatisticsFeatureRef).get(); | ||
| _engineSelectorFeature = std::move(_lazyEngineSelectorFeatureRef).get(); | ||
| _clusterMetricsFeature = std::move(_lazyClusterMetricsFeatureRef).get(); | ||
| _clusterFeature = std::move(_lazyClusterFeatureRef).get(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we assert somehow that prepare() and therefore get() methods are really called only once?
There was a problem hiding this comment.
It is asserted that get() is called only once: https://github.com/arangodb/arangodb/pull/20945/files?show-viewed-files=true&file-filters%5B%5D=#diff-ba7c32ee3716b0719387545111a837bd0a213f052957a14db2d32b9ee24be3ccR103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Make the dependencies of MetricsFeature explicit, so it can get by without getFeature calls, so it can be an ApplicationFeature instead of an ArangodFeature, so it can be used separately from it.
In order to achieve that, this PR introduces LazyApplicationFeatureReference to handle potential circular references in the feature dependencies (which we should try to get rid of later, whenever possible).
Related Information