Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artificial upper bounds for IO threads configuration #20944

Merged
merged 1 commit into from
May 17, 2024

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #20922

  • remove artificial limit of 8 for the number of ClusterComm IO threads (--network.io-threads)
  • remove artificial limit of 64 for the number of GeneralServer IO threads (--server.io-threads)
  • 馃挬 Bugfix
  • 馃崟 New feature
  • 馃敟 Performance improvement
  • 馃敤 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 馃摉 CHANGELOG entry made
  • 馃摎 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

* Remove artificial upper bounds for the command-line options regarding the
  number of IO threads: `--server.io-threads` and `--network.io-threads` were
  previously limited to 64 and 16, resp. Now there is no upper bound for these
  options anymore. The default values remain unchanged.
@jsteemann jsteemann added this to the 3.11 milestone May 16, 2024
@cla-bot cla-bot bot added the cla-signed label May 16, 2024
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KVS85 KVS85 merged commit 5d7a24b into 3.11 May 17, 2024
2 of 3 checks passed
@KVS85 KVS85 deleted the feature-3.11/remove-artificial-iothreads-limit branch May 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants