Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip fuerte timeout tests on Windows #20943

Merged
merged 1 commit into from
May 17, 2024

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

the fuerte timeout tests are unreliable and often fail with "Request timeout" messages on Windows. disable them on Windows only.

this fixes spurious test failures such as

=== fuerte_http ===
* Test "fuerte"
    [FAILED]  fuerte

      "test" failed: exit code of 'Thu May 16 2024 02:16:04 GMT+0200 (Central European Summer Time) executeAndWait: cmd =build\bin\RelWithDebInfo\fuertetest.exe args =["--gtest_output=json:c:\\gce-win-0v8vdp\\oskar\\work\\tmp\\ArangoDB\\46\\arangosh_a25384\\fuertetest\\testResults.json","--log.line-number","false","--endpoint=tcp://127.0.0.1:12124","--authentication=basic:root:"]' was 1

    [FAILED]  RequestTimeout

      "test" failed: C:\gce-win-0v8vdp\oskar\work\ArangoDB\tests\Fuerte\ConnectionTimeoutsTest.cpp:110
Expected equality of these values:
  e
    Which is: 2-byte object <EB-03>
  fu::Error::NoError
    Which is: 2-byte object <00-00>
C:\gce-win-0v8vdp\oskar\work\ArangoDB\tests\Fuerte\ConnectionTimeoutsTest.cpp:110
Expected equality of these values:
  e
    Which is: 2-byte object <EB-03>
  fu::Error::NoError
    Which is: 2-byte object <00-00>

there is intentionally no forward port of these changes to devel, as in devel all Windows-related code has been removed previously.

  • 馃挬 Bugfix
  • 馃崟 New feature
  • 馃敟 Performance improvement
  • 馃敤 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 馃摉 CHANGELOG entry made
  • 馃摎 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

the fuerte timeout tests are unreliable and often fail with "Request
timeout" messages on Windows. disable them on Windows only.
@jsteemann jsteemann added this to the 3.11 milestone May 16, 2024
@cla-bot cla-bot bot added the cla-signed label May 16, 2024
@KVS85 KVS85 merged commit 4e7176f into 3.11 May 17, 2024
2 of 3 checks passed
@KVS85 KVS85 deleted the bug-fix-3.11/skip-fuerte-timeout-tests branch May 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants