Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

make latest indexes visible #20942

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Backport of #20941

make latest indexes visible when calling GET /_api/index?withHidden=true.
we need to wait here for the latest index information being present in the agency cache. if we don't wait, we risk not seeing a just-created index if the local agency cache has not fully caught up, and the supervision declares the just-created index ready.

This fixes spurious test errors such as

=== shell_client_3 ===
* Test "shell_client_3"
    [FAILED]  tests/js/client/shell/shell-index.js

      "testIndexProgressIsReported" failed: Error: at assertion #31: [ { "fields" : [ "_key" ], "id" : "c0l/0", "name" : "primary", "selectivityEstimate" : 1, "sparse" : false, "type" : "primary", "unique" : true } ]: (1) is not equal to (2)
(Error
    at Object.testIndexProgressIsReported (tests/js/client/shell/shell-index.js:98:9)
    at tests/js/client/shell/shell-index.js:167:11
    at tests/js/client/shell/shell-index.js:171:3
...    at Object.shellClient [as shell_client] (/work/ArangoDB/js/client/modules/@arangodb/testsuites/aql.js:226:79)
 - test failed
  • 馃挬 Bugfix
  • 馃崟 New feature
  • 馃敟 Performance improvement
  • 馃敤 Refactoring/simplification

Checklist

  • Tests
    • Regression tests
    • C++ Unit tests
    • integration tests
    • resilience tests
  • 馃摉 CHANGELOG entry made
  • 馃摎 documentation written (release notes, API changes, ...)
  • Backports
    • Backport for 3.12.0: -
    • Backport for 3.11: -
    • Backport for 3.10: -

Related Information

  • Docs PR:
  • Enterprise PR:
  • GitHub issue / Jira ticket:
  • Design document:

when calling GET /_api/index?withHidden=true.
we need to wait here for the latest index information being present in
the agency cache. if we don't wait, we risk not seeing a just-created
index if the local agency cache has not fully caught up, and the
supervision declares the just-created index ready.
@jsteemann jsteemann added this to the 3.11 milestone May 16, 2024
@jsteemann jsteemann requested a review from a team as a code owner May 16, 2024 11:18
@cla-bot cla-bot bot added the cla-signed label May 16, 2024
@KVS85 KVS85 merged commit e677f28 into 3.11 May 17, 2024
2 of 3 checks passed
@KVS85 KVS85 deleted the bug-fix-3.11/make-latest-indexes-visible branch May 17, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants