Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show custom widget icon reliably when no widget is found #33535

Merged
merged 1 commit into from
May 20, 2024

Conversation

raza001
Copy link
Contributor

@raza001 raza001 commented May 17, 2024

Steps To Reproduce
go to edit mode of the application
In the entity explorer section click on UI tab
search for the widget name which is not present
The custom widget icon will be displayed but seems like broken as in attached screenshot

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

Walkthrough

The UIEntitySidebar component in the app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx file was updated to modify the Flex component's class name. The change involved adding the flex-col class to the existing class list, which adjusts the layout direction of the Flex component to be column-oriented.

Changes

File Path Change Summary
app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx Modified the Flex component's class from "flex-grow px-3 overflow-y-scroll" to "flex-grow px-3 overflow-y-scroll flex-col" to change the layout direction to column.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8aeb900 and d5b81ef.
Files selected for processing (1)
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mohanarpit mohanarpit requested a review from jsartisan May 17, 2024 07:10
@mohanarpit mohanarpit changed the title The custom widget Icon is solved fix: Show custom widget icon when no widget is found May 17, 2024
@mohanarpit mohanarpit changed the title fix: Show custom widget icon when no widget is found fix: Show custom widget icon reliably when no widget is found May 17, 2024
Copy link
Contributor

@jsartisan jsartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

just curious @albinAppsmith when did this break? 🤔

@albinAppsmith
Copy link
Collaborator

@jsartisan I guess this was broken after building blocks.

@mohanarpit mohanarpit merged commit 600901f into appsmithorg:release May 20, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants