Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable manual run on limited test workflow #33534

Merged
merged 2 commits into from
May 17, 2024
Merged

Conversation

sharat87
Copy link
Member

The step to get the PR number when run manually has error in its code. The res= line doesn't work, in that it'll mangle the JSON output from the curl command, before setting it into the variable. It should've been

res="$(curl ...)"

Considering we don't use this functionality today, and it doesn't work either, we're removing it.

This workflow is only used with repository_dispatch, and we make that explicit.

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

Walkthrough

The workflow file .github/workflows/build-client-server.yml has been simplified by removing the manual triggering options and the associated logic. This results in a more streamlined process where the matrix jobs are directly set, and arguments for PR and run ID are assigned based on the event payload without additional conditional checks.

Changes

File Path Change Summary
.github/workflows/build-client-server.yml Simplified workflow by removing manual triggering options and related logic. Matrix jobs are now directly set to [0, 1, 2], and arguments for PR and run ID are directly assigned from event payload.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8aeb900 and 419bede.
Files selected for processing (1)
  • .github/workflows/build-client-server.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/build-client-server.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels May 17, 2024
@sharat87 sharat87 merged commit 3e06f1a into release May 17, 2024
15 of 16 checks passed
@sharat87 sharat87 deleted the sharat87-patch-3 branch May 17, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants