chore: Remove incorrect and unused update signature

[sharat87]

The update method with String, T, String signature, is not used in it's form anywhere. This is most likely owing to the implementation being off. The criteria used to find the object to be updated, is not the same as the criteria used to find the updated object to return to the caller.

The query to update is {value of key field} = id.

The query to find is {value of "id" field} = id.

This discrepency is likely why this function is not used anywhere. The ApplicationServiceCE alone has an overridden implementation for this signature, but that's defined with different variable names, and treats the third argument as the Git branch name, not key. That function is indeed used, and is unaffected by this change.

All of above is verified on EE as well. No conflicts, no build failure.

/ok-to-test tags="@tag.Sanity"

[github-actions]

Failed server tests

• com.appsmith.server.services.UserServiceTest#updateNameOfUser
• com.appsmith.server.services.UserServiceTest#updateNameOfUser_WithAccentedCharacters_IsValid
• com.appsmith.server.services.UserServiceTest#updateNameProficiencyAndUseCaseOfUser
• com.appsmith.server.services.UserServiceTest#updateNameRoleAndUseCaseOfUser

[coderabbitai]

Walkthrough

Walkthrough

The recent updates enhance the update method in the BaseService class by simplifying its signature and refining its logic. Furthermore, the UserServiceCEImpl class now leverages updateWithoutPermission instead of update for altering the current user, adjusting how permissions are managed during user updates.

Changes

Files	Change Summary
app/server/appsmith-server/src/main/java/com/appsmith/server/services/BaseService.java	Simplified update method by consolidating functionality and removing overloaded version.
app/server/appsmith-server/src/main/java/com/appsmith/server/services/UserServiceCEImpl.java	Updated updateCurrentUser to use updateWithoutPermission, altering user update permission handling.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between eab36bc and bfb667f.

Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/services/BaseService.java (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/services/BaseService.java

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sharat87]

UserServiceCE is the only service that overrides the update method, to do a permission check, and has its own updateWithoutPermission separately. I intend to fix that inconsistency as well, in a separate PR.