Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replacing "Edition" with "Plan" for business and enterprise edition references #33506

Merged
merged 2 commits into from
May 17, 2024

Conversation

ankitakinger
Copy link
Contributor

@ankitakinger ankitakinger commented May 16, 2024

Description

Replacing "Edition" with "Plan" for business and enterprise edition references.

Fixes #1415

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Caution

🔴 🔴 🔴 Some tests have failed.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9123234678
Commit: 53ccc6c
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/SettingsPane/EmbedSettings_spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Copy link
Contributor

coderabbitai bot commented May 16, 2024

Walkthrough

Walkthrough

The changes involve updating text references from "Business Edition" to "Business plan" across various files in both the client and server codebases. Additionally, a bug fix addresses an issue where datasource configurations were incorrectly read from the action object instead of the datasource object, causing null pointer exceptions in certain scenarios.

Changes

Files Change Summary
.../Branding/Branding_spec.js, .../PrivateEmbedRamp_spec.ts, .../HomePage.ts Updated text references from "Business Edition" to "Business plan" in assertions and functionality checks.
.../constants/messages.ts, .../PartialExportModal/unitTestUtils.ts, .../dropTarget/unitTestUtils.ts Changed string constants and business logic conditions from "business edition" to "Business plan".
app/server/.../AccessControlConstantsCE.java Modified string constant related to accessing roles and groups for conditional business logic.

Assessment against linked issues

Objective Addressed Explanation
Fix reading datasource configuration from the action object instead of the datasource object (#1415)

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between ca4839e and 53ccc6c.
Files selected for processing (2)
  • app/client/cypress/e2e/Regression/ClientSide/Branding/Branding_spec.js (1 hunks)
  • app/client/src/ce/constants/messages.ts (7 hunks)
Files skipped from review as they are similar to previous changes (2)
  • app/client/cypress/e2e/Regression/ClientSide/Branding/Branding_spec.js
  • app/client/src/ce/constants/messages.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ankitakinger
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9106717039.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 33506.
recreate: .

Copy link

Deploy-Preview-URL: https://ce-33506.dp.appsmith.com

@ankitakinger ankitakinger added the ok-to-test Required label for CI label May 17, 2024
Copy link
Contributor

@brayn003 brayn003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ankitakinger ankitakinger requested review from nsarupr and removed request for nidhi-nair May 17, 2024 06:59
Copy link
Contributor

@nsarupr nsarupr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@sharat87 sharat87 merged commit 4bb0af4 into release May 17, 2024
79 of 81 checks passed
@sharat87 sharat87 deleted the chore/remove-edition-references branch May 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants