Remove dependency of SILFunction in IRGenOptions #73727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
slavapestov
reviewed
May 18, 2024
lib/SIL/IR/SILFunction.cpp
Outdated
| options->LLVMLTOKind != IRGenLLVMLTOKind::None) { | ||
| return false; | ||
| } | ||
| const auto &silOptions = getModule().getOptions(); |
There was a problem hiding this comment.
Why not just add a bool ShouldBePreservedByDebugger to SILOptions? Then you don’t have to much a bunch of stuff around.
augusto2112
force-pushed
the
remove-dep-irgen
branch
from
99015cf
to
956668f
Compare
|
@swift-ci smoke test |
SILFunction::shouldBePreservedForDebugger checks if some optimizations are enabled to decide whether a function should be preserved so its accessible form the debugger or not. Some of these settings used to live only in IRGenOptions making SILFunction depend on IRGenOptions.
augusto2112
force-pushed
the
remove-dep-irgen
branch
from
956668f
to
4aec4e7
Compare
|
@swift-ci test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SILFunction::shouldBePreservedForDebugger checks if some optimizations are enabled to decide whether a function should be preserved so its accessible form the debugger or not. Some of these settings used to live only in IRGenOptions making SILFunction depend on IRGenOptions. This patch duplicates those settings into SILOptions to remove that dependency.