-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override flags that prevent package-cmo if allow-non-resilient-access is enabled #73717
Conversation
if (LangOpts.AllowNonResilientAccess) | ||
Diags.diagnose(SourceLoc(), diag::warn_ignore_option_overriden_by, | ||
"-experimental-skip-non-inlinable-function-bodies-without-types", | ||
"-experimental-allow-non-resilient-access"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests for these newly added warnings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it won't be merged without tests; this just unblocks things.
@swift-ci smoke test |
@swift-ci smoke test |
@swift-ci smoke test linux |
@swift-ci smoke test windows |
Flags that skip non-inlinable function bodies prevent serializing decls when package-cmo is enabled.
This PR overrides such flag if allow-non-resilient-access that is a prerequisite of package-cmo is passed.
rdar://128413200