embedded: fix a compiler crash when using dynamic casts #73703
Merged
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
eeckstein
force-pushed
the
fix-cast-simplification
branch
from
2ce4c2f
to
1becb0b
Compare
|
@swift-ci test |
…types match Fixes a crash when creating a copy_addr with mismtaching types. rdar://128195403
Dynamic casts need metadata and therefore cannot be used in embedded swift. Fixes an internal IRGen error.
eeckstein
force-pushed
the
fix-cast-simplification
branch
from
1becb0b
to
369021f
Compare
|
@swift-ci test |
kubamracek
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in SimplifyCheckedCast: only simplify if source and destination address types match
Also diagnose dynamic casts to avoid an internal IRGen error:
rdar://128195403