Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SE-0306 Actors: Make Types consistent in re-entrancy sample code #2447

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

Diggory
Copy link
Contributor

@Diggory Diggory commented May 10, 2024

I have been reading up on Actors, and think that there are some Type name errors in the sample code. Forgive me if I have misunderstood and got this wrong....

In the re-entrancy section there is some sample code showing how a value can change across awaits.

The types don't match - I suspect that at some point Person was changed to DecisionMaker but not all occurrences of the type name were changed in the sample code.

The Actor type should either be a Person or a DecisionMaker Similarly the opinion property's type should either be Judgment or 'Decision'

The Actor type should either be a `Person` or a `DecisionMaker`
Similarly the `opinion` property's type should either be `Judgment` or 'Decision'
@Diggory Diggory changed the title 0306-Actors: Make Types consistent in re-entrancy sample code SE-0306 Actors: Make Types consistent in re-entrancy sample code May 10, 2024
Copy link
Member

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah seems the type was renamed huh, thanks for catching it

@ktoso ktoso merged commit 433548a into apple:main Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants