-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFC] Fix diagnostic message query formatting for compatibility with existing tests, and fix additional tests #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci test |
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 16, 2024 16:08
462e49a
to
8006132
Compare
@swift-ci test |
owenv
approved these changes
May 16, 2024
nkcsgexi
approved these changes
May 16, 2024
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 16, 2024 22:00
8006132
to
ba09781
Compare
@swift-ci test |
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 17, 2024 15:26
ba09781
to
5c8c04d
Compare
artemcm
changed the title
[Test] Fix
[NFC] Fix diagnostic message query formatting for compatibility with existing tests
May 17, 2024
testParallelDependencyScanningDiagnostics
to handle new diagnostics with source-locations
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 17, 2024 15:27
5c8c04d
to
c525641
Compare
artemcm
changed the title
[NFC] Fix diagnostic message query formatting for compatibility with existing tests
[NFC] Fix diagnostic message query formatting for compatibility with existing tests, and fix additional tests
May 17, 2024
@swift-ci test |
@swift-ci test Windows platform |
1 similar comment
@swift-ci test Windows platform |
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 20, 2024 17:54
c525641
to
80ccc07
Compare
@swift-ci test |
artemcm
force-pushed
the
FixDepScanDiagTestForSourceLoc
branch
from
May 20, 2024 18:25
80ccc07
to
b65045f
Compare
@swift-ci test |
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.