-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for load-pass-plugin
option
#1472
base: main
Are you sure you want to change the base?
Add support for load-pass-plugin
option
#1472
Conversation
cc/ @artemcm, @lhames, @DougGregor. |
@@ -435,6 +435,10 @@ extension Driver { | |||
commandLine.appendFlag(.pluginPath) | |||
commandLine.appendPath(pluginPathRoot.localPluginPath) | |||
} | |||
|
|||
if let passPluginPath = parsedOptions.getLastArgument(.loadPassPluginEQ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also guard this with:
isFrontendArgSupported(.loadPassPluginEQ)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guarded, thanks!
Please add a simple test that the flag is propagated to the expected |
d41ec65
to
916a707
Compare
Rebased to main, and added a test forwarding the options to the frontend, thanks! |
916a707
to
3128d28
Compare
Rebased to main, solved conflicts. |
`Options.swift` has been regenerated so as to include `load-pass-plugin` option as well.
3128d28
to
b6bb0f2
Compare
Options.swift
has been regenerated so as to includeload-pass-plugin
option as well.Frontend implementation at apple/swift#68985.