[6.0] Adopt SwiftPM ModulesGraph initializer API adjustment #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
apple/swift-package-manager#7541 |
ahoppen
approved these changes
May 8, 2024
bnbarham
approved these changes
May 8, 2024
`ModulesGraph.init` was changed by apple/swift-package-manager#7530 to accept `packages` as a way to avoid having to recompute the full list of packages by walking roots. (cherry picked from commit 2270631) (cherry picked from commit b13244f)
xedin
force-pushed
the
adopt-modulesgraph-api-change-6.0
branch
from
b13244f
to
9f6021c
Compare
|
apple/swift-package-manager#7541 |
1 similar comment
|
apple/swift-package-manager#7541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Cherry-pick of Adopt SwiftPM ModulesGraph initializer API adjustment #1233 paired with [6.0][Package/ModuleGraph] Allow cyclic package dependencies if they don't introduce a cycle in a build graph swift-package-manager#7541
ModulesGraph.initwas changed by [Package/ModuleGraph] Allow cyclic package dependencies if they don't introduce a cycle in a build graph swift-package-manager#7530 to acceptpackagesas a way to avoid having to recompute the full list of packages by walking roots.Scope: NFC change
Main Branch PRs: Adopt SwiftPM ModulesGraph initializer API adjustment #1233
Risk: Very Low
Reviewed By: @ahoppen
Testing: No new tests are necessary
(cherry picked from commit 2270631)