Filter backticks in TestItem IDs #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
reviewed
May 1, 2024
Backticks in TestItem IDs should be sanitized. Use the new TokenSyntax.identifier when building up the TestItem IDs.
plemarquand
force-pushed
the
fix-backticks-in-test-ids
branch
from
1ac0685
to
7734133
Compare
ahoppen
reviewed
Jun 3, 2024
ahoppen
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Thank you. Looks great.
Let’s wait until apple/swift-syntax#2666 is merged before merging this PR because it makes my life of getting this change into release/6.0 easier.
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test functions with backticks in their identifier should have them filtered out.
This is a stopgap until apple/swift-syntax#2576 is ready.