Enhance header name validation exception message (approach 1) #2923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Provide more details about a illegal header name.
Modifications:
IllegalCharacterException
inHeaderUtils
and rewrap inStacklessIllegalArgumentException
with additional context (token value);Result:
Users can see what header name has an illegal character.
This approach optimizes for a "happy path".
When users add/set illegal header name:
before
after
When an illegal header name is received over network:
before
after