-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Swift clang-linker path #8748
Set Swift clang-linker path #8748
Conversation
@swift-ci please test |
fa8dce4
to
4f4af8f
Compare
@swift-ci please test |
Can you rebase this PR on |
4f4af8f
to
1f6bd55
Compare
Done, and here's the cherry-pick: |
@swift-ci please test |
@swift-ci please test macOS platform |
577dd53
to
fb64ef9
Compare
The swift driver is picking up the system clang instead of using the clang set in `CC`. The system clang is attempting to use bfd to link Swift, which doesn't work due to Swift's protected symbol usage. Set the swift-driver tool directory based on the location of the clang in use to ensure that we're picking up a consistent set of tools across all of the tests.
fb64ef9
to
2c8a5e6
Compare
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner!
Don't forget to cherry-pick -x this to |
@swift-ci please test |
Cherry-pick PR: #8759 |
The swift driver is picking up the system clang instead of using the clang set in
CC
. The system clang is attempting to use bfd to link Swift, which doesn't work due to Swift's protected symbol usage.rdar://123061492
rdar://127628654