[Issue #14] Recommend explicit mentioning of Python version for creating virtual environment #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified in README.md that Python version 3.11 is recommended for creating the virtual environment using venv. This ensures compatibility with the current version and allows for future flexibility.
Miskovi
approved these changes
Apr 28, 2024
rezashahnazar
changed the title
|
Thank you very much for your contribution, @rezashahnazar . Currently, we can confirm that CoreNet can be installed on python-3.9, as specified in https://github.com/apple/corenet/blob/main/tox.ini. Apparently, there is an issue with python-3.12 that is reported on #14. We prefer to make CoreNet installable on all python versions >=3.9, including 3.12, if possible. Thus, I'm closing this PR but will keep #14 open and please feel free to open a PR that fixes the issue with all 3.9+ versions including 3.12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarified in README.md that Python version 3.11 is recommended for creating the virtual environment using venv. This ensures compatibility with the current version and allows for future flexibility.