Update setup.py #15
Open
Update setup.py #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammad7t
reviewed
May 2, 2024
There was a problem hiding this comment.
Thank you for your contribution and suggestions, @AssiamahS ! We might relax the python_requires in a future release, but since we haven't tested CoreNet with python<=3.8 yet, we will need to keep the minimum version requirement as is for now.
Could you please revert the change to python_requires in this PR so that we can merge it while we work on python version requirement?
Revert "Update python_requires in setup.py" This reverts the change made to the python_requires value in setup.py file. The original version requirement is reinstated to maintain compatibility with python<=3.8 until further testing is conducted with CoreNet. Reference: apple#15
|
The diff seems to be empty now. I think ecbece3 looked good except line 92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code looks mostly good, but there are a few minor spelling errors and improvements that can be made for clarity and consistency:
In the comment block at the beginning, "copyright" is misspelled as "copyrigth."
"parse_requirements" function: The function name and docstring should be consistent with the British English spelling of "requirements."
"is_internal" variable: The variable name is clear, but consider adding a comment explaining its purpose.
"dev_requirement_regex" variable: "Requirement" should be pluralized as "Requirements" for consistency.
In the setup function:
"python_requires" should specify the minimum required Python version as ">=3.6" since the code checks for Python 3.6 compatibility.
"setuptools" version should be specified as "setuptools>=18.0" for consistency with other requirements.